Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application using this library #63

Merged
merged 1 commit into from Aug 27, 2021
Merged

Add application using this library #63

merged 1 commit into from Aug 27, 2021

Conversation

cyb3rko
Copy link
Contributor

@cyb3rko cyb3rko commented Aug 26, 2021

Hey there again,
you have stated the following in the README:
"Anyone else using the library in their application, i'd love to hear and put a link up here."

I developed an android application around this library, so I would really appreaciate it if you would add my app to this list :).

Here the link again: https://github.com/cyb3rko/pazzword

@Tostino Tostino merged commit 57be992 into GoSimpleLLC:master Aug 27, 2021
@Tostino
Copy link
Collaborator

Tostino commented Aug 27, 2021

Checked out the app, quite nice looking! Merged.

@cyb3rko
Copy link
Contributor Author

cyb3rko commented Aug 27, 2021

Thanks a lot!
One simple question:

I create a custom dictionary with additional passwords like this:

val dictionary = DictionaryBuilder()
    .setDictionaryName("custom_passwords")
    .addWords(lineList, 200)
    .setExclusion(false)
    .createDictionary()

I'm not really sure what to put in the method 'addWords' as the second parameter as the passwords don't really have a rank which fits to the 30k stored passwords in the library.
Can you try to explain what to put there again?

@Tostino
Copy link
Collaborator

Tostino commented Sep 2, 2021

If you are using an unranked dictionary, just pass in 0 for all words.

@cyb3rko cyb3rko deleted the patch-1 branch September 2, 2021 15:42
@Tostino
Copy link
Collaborator

Tostino commented Sep 2, 2021

You know what, I think I am wrong on that one. Looking through DictionaryUtil, I have a helper to load an "unranked" dictionary, and it loads all words with the same rank, but it's not 0. If we were loading 1000 words into the dictionary, it puts them all in with a rank of 500.

If I remember right, this is to make sure the scoring is consistent between the other dictionaries that do have ranks, and unranked dictionaries. This isn't very clean and it would be something to clean up at some point. It'd be better to just have the dictionary itself know if it's ranked, or unranked and provide the appropriate values for scoring without having to manually deal with it.

@cyb3rko
Copy link
Contributor Author

cyb3rko commented Sep 2, 2021

Okay, I think I will then continue using my custom rank value 200 (it works okay, sooo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants