You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the right thing to do is output the PSBT if a transaction is not finalized after signing. They should be output to psbt-output-dir (default should be $GUN_DIR/psbts). The filename should be <tentative-txid>.psbt. You can get the tentative-txid by doing psbt.extract_tx().txid().
At the moment let's just hang and wait for the user to sign the PSBT there. Whenever they press enter read the file back in and check if it has been signed. Once it has been signed, broadcast it.
Choosing the network
Right now we have a mandatory <network> argument to init. This should just be made into a optional --network argument with the default being "bitcoin"
Init with seed
The existing gun init should go under gun init seed.
The text was updated successfully, but these errors were encountered:
We should be able to initialize the wallet with an arbitrary descriptor like
gun init <external-descriptor> [<internal-descriptor>]
With no change descriptor:
With a change descriptor:
The above should simplify to the below:
Implementation
I think the way this information should be stored should just be in the WalletKey enum like:
And in the config.json like:
Signing
I think the right thing to do is output the PSBT if a transaction is not finalized after signing. They should be output to
psbt-output-dir
(default should be$GUN_DIR/psbts
). The filename should be<tentative-txid>.psbt
. You can get the tentative-txid by doingpsbt.extract_tx().txid()
.At the moment let's just hang and wait for the user to sign the PSBT there. Whenever they press enter read the file back in and check if it has been signed. Once it has been signed, broadcast it.
Choosing the network
Right now we have a mandatory
<network>
argument toinit
. This should just be made into a optional--network
argument with the default being "bitcoin"Init with seed
The existing
gun init
should go undergun init seed
.The text was updated successfully, but these errors were encountered: