Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clean.js design fully OO #138

Closed
GoalSmashers opened this issue Sep 4, 2013 · 2 comments
Closed

Make clean.js design fully OO #138

GoalSmashers opened this issue Sep 4, 2013 · 2 comments
Assignees
@GoalSmashers
Milestone
2.0

Comments

@GoalSmashers
Copy link
Contributor

It should go like this:

var CleanCSS = require('clean-css');
new CleanCSS(options).process(data);

It's an API breaking change so it should be brought with 2.0 release.
We should also make sure it is possible to run many clean up operations simultaneously.
@ghost ghost assigned GoalSmashers Sep 4, 2013
This was referenced Sep 7, 2013
Closed
Closed
GoalSmashers pushed a commit that referenced this issue Nov 3, 2013
Fixes #138 - makes CleanCSS interface fully object oriented.
9899929 
* use `new CleanCSS(options).minify(css)` to minify CSS.
* adds 1.x -> 2.x migration info
@GoalSmashers
Copy link
Contributor Author

@XhmikosR comments re 9899929 are welcome!

I opted for new CleanCSS(options).minify(css) instead as process it too generic plus it clashes with process global variable.

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 3, 2013

I think it looks good @GoalSmashers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GoalSmashers GoalSmashers

Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@XhmikosR @GoalSmashers