-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaks Irregular CSS content #155
Comments
It actually should not even get to this point since we escape all strings to prevent such situations. Here it doesn't work so consider your challenge accepted! |
@GoalSmashers Thanks! Here is a correction: Before clean-css body::before {
content: '{ "current" : "small", "all" : ["small"], "position" : 0 }';
display: none;
} Notice, the quotes ( |
* ["content"] is an invalid CSS but it was matched as an attribute. * If placed inside content property value it was matched BEFORE we escape all free text.
@jpdesigndev - you identified the place correctly as we actually strip quotation from CSS attributes BEFORE escaping all text. And It is fixed now and 1.1.6 is out. Thanks for bringing it into our attention! |
@GoalSmashers Thank you! Your awesome. I haven't been able to test on my end yet, because I can't figure out how to update a dependencie's dependency as documented here. |
@GoalSmashers Got it. I had to remove the modules in my node_modules folder, and reinstall them with |
Glad you got it. 👍 Seems like that's the problem with |
I have documented the issue here.
This seems to be the problem area, but my regex chops are no where near capable of fixing it, unfortunately.
The text was updated successfully, but these errors were encountered: