-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.0.0 + 2.0.1 break [concatenated] some CSS files, older V1.1.3 - V1.1.7 is fine @ CLI Use #177
Comments
@peterbowey We changed quite a lot of things in 2.0.x (thus major version change) which may result in this incorrect behaviour. Could you please share your CSS via gist or email it to dev(at)goalsmashers.com so we can track down the bug? |
Also, if you skip advanced processing the output files should be like with v1.x. But as @GoalSmashers says please share your CSS. |
@peterbowey thanks for the files! Here are two quick questions regarding them:
|
@GoalSmashers B) I suspect it is the 2nd or 3rd [in order] CSS file I sent, as I remember opening this CSS asset in Firefox source [direct] to see just one CSS style 'invocation , rather than the normal 100+ it has.
----- Original Message ----- @peterbowey thanks for the files! Here are two quick questions regarding them:
— |
That helps a lot - all the feedback is much appreciated! Will update you as soon as we find out why it fails. |
* Adds a warning on an incorrect content or a closing parenthesis.
@peterbowey clean-css 2.0.2 is out with a fix to your case. The fact is that your CSS has an invalid part at the end of line 54 - Minified CSS seems to be OK however it would be better to fix the warning. |
* Adds a warning on an incorrect content or a closing parenthesis.
@GoalSmashers many thanks; and a great tool with the 'warning' info.. |
@peterbowey Great, enjoy! |
I updated to the latest 'clean-css' V2.0.1 (from my older 'clean-css' V1.1.3).
Testing the results found that certain CSS style were concatenated with a resulting incorrect presentation in the client view.
Rolled back to 'clean-css' V1.1.7 and the results were fine.
Tried the 'clean-css' V2.0.0 and the same client side issue occurred [concatenation of some styles] - with incorrect client side presentation.
This is about a CLI use of 'clean-css', and not any 'node.js' use.
I notice that some CLI options have changed in the newer V2.0.+, however I have not yet determined what causes this 'error', as there are not logs, just an abrupt concatenation on some style CSS?
Comparing the older 'clean-css' CLI commands to the new 2.0.x, I note these changes:
[-e, --remove-empty] does not exist in the new
[--skip-advanced] has been added to the new
[--selectr-merge-mode |ie8[*]] has been added to the new
The only CLI command I have been using for all these versions has been [-o, --output [output-file]], as in "cleancss -o public.css public.css"
For now, my working solution is to the use the 'clean-css' V1.1.7
The text was updated successfully, but these errors were encountered: