Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep quotes for font-name with digits #191

Closed
HugoHeneault opened this issue Dec 15, 2013 · 8 comments
Closed

Keep quotes for font-name with digits #191

HugoHeneault opened this issue Dec 15, 2013 · 8 comments

Comments

@HugoHeneault
Copy link

Hello,

First, thanks for your great work !

I have an error with digits in font-name. The font-name isn't recognized anymore.

As seen on W3C's website : "To avoid mistakes in escaping, it is recommended to quote font family names that contain white space, digits, or punctuation characters other than hyphens."

Example :

body { font-family: "New Century Schoolbook", serif }

<BODY STYLE="font-family: '21st Century', fantasy">

It seems that clean-css doesn't handle exactly font-name property like this : font-family: '123font' becomes font-family: 123font.

Can you fix this ?

Thanks !
@GoalSmashers
Copy link
Contributor

Thanks Hugo for reporting this issue - does it happen with the most recent 2.0.2 release?

Sent from my iPad

On Dec 15, 2013, at 13:13, Hugo Heneault notifications@github.com wrote:

Hello,

First, thanks for your great work !

I have an error with digits in font-name. The font-name isn't recognized anymore.

As seen on W3C's website : "To avoid mistakes in escaping, it is recommended to quote font family names that contain white space, digits, or punctuation characters other than hyphens."

Example :

body { font-family: "New Century Schoolbook", serif }

It seems that clean-css doesn't handle exactly font-name property like this : font-family: '123font' becomes font-family: 123font.

Can you fix this ?

Thanks !

—
Reply to this email directly or view it on GitHub.

@HugoHeneault
Copy link
Author

Actually, I'm using grunt-contrib-cssmin which is on 2.0.0.
Have you done any fixes about this ? I'm gonna ask for an update on cssmin.

Thanks for your reply !

@HugoHeneault HugoHeneault mentioned this issue Dec 15, 2013
Closed
@GoalSmashers
Copy link
Contributor

Ok, so we need to track down where does the change happens on master. Unfortunately cannot push a fix until Wed (not next to a dev machine) so as a temp fix can you rename the font or use an older grunt plugin which used clean-css 1.1?

That should help. Will issue 2.0.3 on Wednesday.

On 15 Dec 2013, at 22:08, Hugo Heneault notifications@github.com wrote:

Actually, I'm using grunt-contrib-cssmin which is on 2.0.0.
Have you done any fixes about this ? I'm gonna ask for an update on cssmin.

Thanks for your reply !

—
Reply to this email directly or view it on GitHub.

@HugoHeneault
Copy link
Author

I already changes my font name as a workaround.
I'm new to clean-css. Not sure this is a regression issue.

Take your time. I'm patient. :)

@GoalSmashers
Copy link
Contributor

Great. Expect an update on Wed!

On 16 Dec 2013, at 09:22, Hugo Heneault notifications@github.com wrote:

I already changes my font name as a workaround.
I'm new to clean-css. Not sure this is a regression issue.

Take your time. I'm patient. :)

—
Reply to this email directly or view it on GitHub.

GoalSmashers pushed a commit that referenced this issue Dec 18, 2013
Fixes #191 - quotes around font name should not be removed if value s…
f777f0e 
…tarts with a digit.
@GoalSmashers
Copy link
Contributor

@in4matik Fix is on 2.0 branch - 2.0.3 update will be out soon.

@GoalSmashers
Copy link
Contributor

@in4matik 2.0.3 is out with the fix. Thanks for patience!

@HugoHeneault
Copy link
Author

Thanks a lot. Keep doing your great job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GoalSmashers @HugoHeneault