Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-css 2.0.4 IE8 issue #197

Closed
XhmikosR opened this issue Dec 23, 2013 · 10 comments
Closed

Clean-css 2.0.4 IE8 issue #197

XhmikosR opened this issue Dec 23, 2013 · 10 comments
Assignees
Milestone

Comments

@XhmikosR
Copy link
Contributor

advanced-off

advanced-on

Folder with all the relevant files: https://dl.dropboxusercontent.com/u/3607425/clean-css_2.0.4_ie8_bug.zip

@XhmikosR
Copy link
Contributor Author

Refs twbs/bootstrap#11977 (comment)

@ghost ghost assigned GoalSmashers Dec 26, 2013
@GoalSmashers
Copy link
Contributor

@XhmikosR currently we assume that the only way to keep repeated properties as they are is by grouping them one after another. This actually should be fixed in 2.1 with the new override logic.

It is all due to this selector:

.show-grid [class^=col-] {
  padding-top:10px;
  padding-bottom:10px;
  background-color:#eee;
  border:1px solid #ddd;
  background-color:rgba(86,61,124,.15);
  border:1px solid rgba(86,61,124,.2)
}

@XhmikosR
Copy link
Contributor Author

OK, thanks for looking into this. For the time being I have turned advanced optimizations off in case that PR is merged before the next clean-css version.

@GoalSmashers
Copy link
Contributor

Let's see if new merging will help here.

@GoalSmashers GoalSmashers modified the milestones: 2.2, 2.1 Feb 13, 2014
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 5, 2014

@GoalSmashers: this seems fixed too after 2.1.8. Can you confirm?

@GoalSmashers
Copy link
Contributor

Finally have hands on IE8 - let me check.

@GoalSmashers
Copy link
Contributor

@XhmikosR Are you sure it is fixed? My tests show otherwise.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 8, 2014

I just re-ran minify.bat from my test case, after having 2.0.8 installed... Then opened IE, set up compatibility mode to 8. Everything works the same with and without advanced optimizations.

@GoalSmashers
Copy link
Contributor

I'll check again!

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 8, 2014

...unless it's because of the properties order. IIRC I made a couple of relevant changes a while ago.

I'll check again when I'm back home.

GoalSmashers pushed a commit that referenced this issue Jun 1, 2014
* Adds border processor so all border declarations are reprocessed into: <width> <style> <color>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants