Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it handle imports and adjust urls? #2

Closed
balupton opened this issue May 31, 2011 · 7 comments
Closed

Does it handle imports and adjust urls? #2

balupton opened this issue May 31, 2011 · 7 comments
Milestone

Comments

@balupton
Copy link

No description provided.

@GoalSmashers
Copy link
Contributor

It does not handle imports as it's been created to optimize CSS declarations only.
For adjusting URLs, embedding images you can try enhance-css or the assets-packager if you need an all-in-one solution to putting all your CSS and JS together.

https://github.com/GoalSmashers/enhance-css
https://github.com/GoalSmashers/assets-packager

@balupton
Copy link
Author

balupton commented Jun 1, 2011

Thanks mate.

Looking at the enhance-css code, it does handle embedding images, but doesn't seem to handle doing the following:

Say if I have the following:

style.css

@import 'a.css';
@import 'b.css';

to:

/* the contents of a.css */
/* the contents of b.css */

Is this planned at some point?

@GoalSmashers
Copy link
Contributor

Right, it doesn't work at the moment, as we don't use @import's at all at GoalSmashers (as we use Less extensively).
But it definitely should be there as it's a core CSS feature.

Could you do us a favor and open a ticket in enhance-css repository?
We should have some spare time this week time to work on it.

@fiznool
Copy link

fiznool commented Apr 10, 2012

Hello. I'm just wondering if this was ever addressed? I'm currently looking at using the Backbone Boilerplate Grunt tasks and it would be awesome if the clean-css task could follow @import URLs, similar to how the RequireJS r.js optimiser works.

Thanks!

@GoalSmashers
Copy link
Contributor

Hi Tom,

We don't use @import in our CSS suite thus it's not included at the moment, though we see it useful. We have mixed feelings on including this feature in clean-css as it's more about enhancing CSS (see our enhance-css) rather than optimizing. We will think about including it in somewhere though.

Best,
Jakub

On Apr 10, 2012, at 17:48, Tom Spencerreply@reply.github.com wrote:

Hello. I'm just wondering if this was ever addressed? I'm currently looking at using the Backbone Boilerplate Grunt tasks and it would be awesome if the clean-css task could follow @import URLs, similar to how the RequireJS r.js optimiser works.

Thanks!


Reply to this email directly or view it on GitHub:
#2 (comment)

@GoalSmashers
Copy link
Contributor

@balupton, @fiznool - we are sorry it took so long, but it's finally there. It will be released with clean-css 1.0 in the coming days.

@balupton
Copy link
Author

Woot woot woot! Looking forward to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants