Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug when there are IE hacks #245

Closed
jiangyuan opened this issue Feb 25, 2014 · 3 comments
Closed

bug when there are IE hacks #245

jiangyuan opened this issue Feb 25, 2014 · 3 comments

Comments

@jiangyuan
Copy link

just example:

...
.footer {height:20px;position:relative;}
...
.footer {height:20px\9;}
...

just like this, the cleancss result is:

.footer{position:relative;}.footer{height:20px\9;}

Obviously not I want.

cssclean info:

clean-css@2.1.1
   └── commander@2.1.0
GoalSmashers pushed a commit that referenced this issue Feb 25, 2014
Fixes #245 - incorrect handling of backslash IE hack.
cdc5c8a 
Backslash hack '\9' (which is accepted in IE[678]) should be handled correctly
if ie8 or ie7 compatibility is requested.
@GoalSmashers
Copy link
Contributor

@jiangyuan thanks for bringing it up - it's fixed in 2.1.2 but please make sure you use --compatibility ie8 switch.

@jiangyuan
Copy link
Author

I tried it with --compatibility ie8, worked well!

@GoalSmashers
Copy link
Contributor

Enjoy! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GoalSmashers @jiangyuan