Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with multi line strings #46

Closed
XhmikosR opened this issue Dec 22, 2012 · 7 comments
Closed

bug with multi line strings #46

XhmikosR opened this issue Dec 22, 2012 · 7 comments
Assignees
Milestone

Comments

@XhmikosR
Copy link
Contributor

.test[title="my very long\
title"] {
    background-image: url("very/long/\
path")
}

should become

.test[title="my very longtitle"]{background-image:url("very/long/path")}

and not

.test[title="my very long \title"]{background-image:url("very/long/\path")}
@ghost ghost assigned GoalSmashers Jan 9, 2013
@GoalSmashers
Copy link
Contributor

It's a bigger change as there's a need for special handling of attribute selectors so the values won't get changed. Moving it into 1.0 milestone.

@XhmikosR
Copy link
Contributor Author

This isn't fixed entirely. Using the example from my first post I get:

.test[title="my very long\
title"]{background-image:url("very/long/\
path")}

It's like I use -b but I don't...

@GoalSmashers
Copy link
Contributor

With the last change all strings are preserved as is. Why do you think it should act differently in this case?

@XhmikosR
Copy link
Contributor Author

I personally expect the minified output to be exactly this: minified. It should become as the example I show in the first post, that is without the line breaks.

@GoalSmashers
Copy link
Contributor

I see no idea why anyone would do that but it's indeed 1 character less.

@GoalSmashers
Copy link
Contributor

It's done. Fell free to give it a try.

@XhmikosR
Copy link
Contributor Author

Thanks, now it seems to work perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants