Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding other NPC quests? (Kenneth, Nepheli) #1

Closed
clicksilver opened this issue Mar 19, 2022 · 3 comments
Closed

Adding other NPC quests? (Kenneth, Nepheli) #1

clicksilver opened this issue Mar 19, 2022 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@clicksilver
Copy link
Contributor

Are you taking contributions to adding more questlines for this? I figure it would be easy enough to transcribe the stuff from the wiki as people discover it into this tool. It's really awesome, thanks!

@Gobluebro Gobluebro added the question Further information is requested label Mar 19, 2022
@Gobluebro Gobluebro self-assigned this Mar 19, 2022
@Gobluebro
Copy link
Owner

Yes contributions are welcome. Feel free to fork this project and submit a pull request.

The data for this is located here
Each data file has the structure of

{
    id: "insert GUID here",
    name: "Insert Name Here",
    requirements: [
      {
        id: "insert GUID here",
        description: "Describe requirement here",
      },
      ...
    ]
},

Currently I generally try to summarize quest requirements in my own words from watching youtube videos on the quest line. I try to limit the amount of spoilers as hard as that is. I don't really go into a lot of detail as to describe everything you need to do for a requirement like how to find someone or the path you need to go step by step to get to the place you need to go. This checklist currently is just to help you keep your progress with quests. It shouldn't be a game guide.

But all that being said if you wish to contribute just give it your best judgement and I'll make any required last minute changes.

Thank you!

@clicksilver
Copy link
Contributor Author

It shouldn't be a game guide.

Gotcha, so it sounds like general rules of thumb are:

  1. no specifics (coordinates, directions, etc)
  2. describe steps as events as simply as possible

If I make a PR we can workshop how much is too much detail in the comments then

@Gobluebro
Copy link
Owner

Yep you got it perfectly!

Some things I forgot to mention is just how I try to write certain actions the same generally. That way actions are generally treated with the same directions.

interacting with characters I use "Talk to (x)"

killing a boss I use "Defeat (x)"

if there is dialogue options I use "Select the "(x)" dialogue option."

if grace sites are very close by then I generally include "at the (x) grace".

If you could write things that way I would greatly appreciate it. Thank you!

Also you don't need to include GUIDs if you find yourself doing a lot to generate them. I have an addon in VSCode that I can just general them all at once so you can leave them as id: "" and I'll add them myself once the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants