Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Map Link functionality #27

Closed
davvolun opened this issue Oct 6, 2022 · 2 comments
Closed

Update Map Link functionality #27

davvolun opened this issue Oct 6, 2022 · 2 comments
Assignees
@Gobluebro
Labels
enhancement New feature or request

Comments

@davvolun
Copy link
Contributor

davvolun commented Oct 6, 2022

Partly discussed on PR #25

Idea is to update the map links to be styled nicely, fitting with the design, and with appropriate UI/UX.

Suggestion is to use the JSX.Element (types: description: string | JSX.Element) to allow inline links.

@Gobluebro I'm planning on doing this myself, but please insert any requirements/suggestions.
@Gobluebro Gobluebro self-assigned this Oct 6, 2022
@Gobluebro Gobluebro added the enhancement New feature or request label Oct 6, 2022
@Gobluebro
Copy link
Owner

Should be able to use https://reactjs.org/docs/dom-elements.html#dangerouslysetinnerhtml to add the jsx to the component. Despite the scary name it will be fine.

@Gobluebro
Copy link
Owner

Requested changes completed in 06caa17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gobluebro Gobluebro

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davvolun @Gobluebro