Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dynamic water texture? Texture/tile repetition removal. #23

Open
Dylsnake opened this issue Sep 8, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@Dylsnake
Copy link

Dylsnake commented Sep 8, 2023

First of all, this mod is cool as! 馃槑


I was streaming my game-play to a group of friends, and they were all captivated by the water effects! Someone mentioned that it would look cooler 馃槑 if the default water texture was instead simulated the same as the wakes, but I'm unsure how intensive this would be.
Also, there is only so much that can easily be done with texture packs, and so I was wondering if it could be featured in this mod?


Anyway, here are some ideas I had.

Texture/tile repetition

One of the thing I'd like to see out of this personally.
A way to reduce or completely remove texture repetition from the water surface.
Ether by completely simulating it, or just using fancy texturing.

I don't like traveling over the oceans of Minecraft, and seeing the grid like pattern from the water's texture.

Water ripples at edges/shorelines

I think it would be cool to see ripple effects at the edges of water, maybe even waves at beaches / shorelines.
They don't have to be simulated, and instead could be a simple static animation, but I'd love to see foamy water effects from the waves.
Maybe more wavy in ocean biomes / lots of water, and also stormy weather.

Maybe even jumping on lily pads could create ripples in the water underneath.

Better flowing water?

It think it would be cool if flowing water's texture was simulated, if that isn't too intensive.
Also.
I don't like how the wakes look in flowing water for two reasons. The wakes should move with the flowing water, and they should match the slope/model of the flowing water's surface.


Overall, I'd simply like to see more improvements and water effects added to this mod.

I hope one of these suggestions is useful.

@Lafolie
Copy link

Lafolie commented Sep 8, 2023

Having wakes simulated on every water block surface would be very expensive indeed. The way they currently work is by creating nodes (wake 'tiles') as minimally as possible. You can toggle the debug options in modmenu to visualise the nodes. Unless Goby has some dark voodoo in store, I can't imagine this being feasible.

In lieu of this, may I suggest you try using a shaderpack? The Complementary shaders somewhat fix 2 of your suggestions: it adds wavy normals to water, so that oceans look less repetitive, and it also has water foam (basically just a distance field effect but it looks great). There is a new version of the shaders releasing tonight actually!

The flowing water feature I beleve is experimental, and better support is planned.

@Goby56
Copy link
Owner

Goby56 commented Sep 8, 2023

Glad you're enjoying the mod! You have some very nice ideas which I'll for sure try to implement in the future. The shoreline foam effect is already quite high up on my to do list but I especially liked your suggestion of lily pad ripples. These features will unfortunately have to wait as I'm doing military service for the coming months.

@Goby56 Goby56 added the enhancement New feature or request label Sep 8, 2023
@Dylsnake
Copy link
Author

Dylsnake commented Sep 8, 2023

@Lafolie The way that shaders do it is to mimic realistic water, with reflections and such, and the wavy normals.
I'm on the other hand, in search for a more stylistic approach, maintaining the pixel art theme. I want those wavy normals, but 2d pixelart texture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants