Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wakes are rendered on top of everything in the latest version (0.2.3-Quilt 1.20.1) #46

Closed
NolanHewitt opened this issue Jan 14, 2024 · 25 comments · Fixed by #68
Closed
Labels
bug Something isn't working

Comments

@NolanHewitt
Copy link

huge_2024-01-14_00 38 23

@Goby56 Goby56 added the bug Something isn't working label Jan 15, 2024
@SaltSouls
Copy link

They are also visible through entities. It would seem that their render order is just set incorrectly. This may have to do with the update that allowed wakes to be visible from under the water on fabulous graphics.
2024-01-20_09 16 06

@Goby56
Copy link
Owner

Goby56 commented Jan 21, 2024

I find this really strange as it does not occur for me. Not with blocks or entities. If I would have to guess I would say that this is an issue involving hardware as only some people have the problem.

In order to figure this out, please provide what OS and graphics card you have.

@Goby56 Goby56 changed the title Water effects can be seen through walls using mod version 0.2.3 (Quilt 1.20.1 MC version) Wakes are rendered on top of everything in the latest version (0.2.3-Quilt 1.20.1) Jan 21, 2024
@NolanHewitt
Copy link
Author

I have two separate system and it occurs on both. One is a laptop 3060, the other is a desktop 7900xtx.

@SaltSouls
Copy link

SaltSouls commented Jan 21, 2024

I have two separate system and it occurs on both. One is a laptop 3060, the other is a desktop 7900xtx.

Are they both running Linux by chance? I'm running Linux, and I know the last set of issues were specifically happening to people running Linux systems.

@NolanHewitt
Copy link
Author

No, I’m using Windows 11 on both.

@ErakAcheron
Copy link

I can also confirm this bug for 1.20.1 Fabric on Windows 10 with an Nvidia 3060 graphics card, I was also running the Nvidium mod (which has worked fine with wakes previously), alongside Sodium, Lithium, Iris and Starlight

@Goby56
Copy link
Owner

Goby56 commented Jan 27, 2024

Does this only occur with Wakes 0.2.3 or is it present in earlier versions as well?

@Blobbon
Copy link

Blobbon commented Jan 30, 2024

It only occurs on wakes 0.2.3 for me

@SaltSouls
Copy link

Yeah, only on the newest version for me as well.

@Billnotic
Copy link

I have this issue too.

@Treetrain1
Copy link

i also have this issue on 0.2.3
more interestingly it renders through water too
(there is water in a lush cave below)
image

@HaipaDev
Copy link

Same issue 0.2.3, I suspected Nvidium for messing with how the shaders are rendered, not sure why everybody here is experiencing it as well

@CocoManiaDX
Copy link

Can confirm on Fabric 1.20.1, Windows 10 with a Radeon RX6600
Only on the 0.2.3 version.
0.2.2 doesn't have the problem.

@NolanHewitt
Copy link
Author

I went back to 0.2.2 like people suggested and that fixes it for me

@Zouzs
Copy link

Zouzs commented Mar 1, 2024

Same hapenning to me.

I tried it on my 1.20.1 modpack and then only with this mod. Newest version (0.1.4) had this problem, i downgraded to the previous one (0.1.3) and it got fixed.

Quilt 0.23.1, Ryzen 5600g, Rx580, Windows 10.

@PolyframeX
Copy link

My specs:

Mod: 0.2.3
Minecraft: 1.20.1
Fabric: 0.15.7
OS: Windows 11.
Graphics: NVIDA GeForce RTX 3070 TI.

@Goby56
Copy link
Owner

Goby56 commented Apr 3, 2024

For the ones that this is happening to. Does it perhaps only occur on fabulous graphic settings?

@Goby56
Copy link
Owner

Goby56 commented Apr 3, 2024

In order to work out what the problem is I need someone who has encountered this problem to change the shader program in the mod's config screen. Try and change it from AUTO to something else like ENTITY_TRANSLUCENT_CULL or GENERAL. You could also play around with the fabulous graphic option and see if that makes any difference.

Thanks for your patience and cooperation! Lets solve this once and for all.

@PolyframeX
Copy link

I was using only Fancy graphic settings. I never use fabulous. I'll try to test out the potential solution when I can.

@Rhett008
Copy link

Rhett008 commented Apr 5, 2024

I have this problem, but only when using shaders. Turning off shaders, I don't experience the issue. I'm using Makeup Ultrafast on 1.20.1. With shaders enabled, I toggled through the different shader program options in the mod's config screen, but nothing fixed it.

OS: Windows 11
GPU: RTX 3060 (laptop)

Minecraft: 1.20.1
Wakes: 0.2.3
Sodium: 0.5.8
Iris: 1.6.17
MakeUp-UltraFast Shaders: 8.9d

Other mods, might be of interest -
Lithium: 0.11.2
Continuity: 3.0.0 beta.4
Indium: 1.0.30
LambDynamicLights: 2.3.2

@Goby56
Copy link
Owner

Goby56 commented Apr 5, 2024

Does downgrading to Wakes 0.2.2 fix it for you @Rhett008 with MakeUp Ultrafast on?

@Goby56
Copy link
Owner

Goby56 commented Apr 7, 2024

Please test out the latest test build and read the instructions in the release notes. (You will have to enable a setting in the config menu)

@PolyframeX
Copy link

PolyframeX commented Apr 7, 2024

The issue seems to be fixed, however it seems to be fixed even the depth debug disabled, so I'm not sure whats going on there. Another thing is weird flickering seems to show up with certain items and things. As shown here: https://github.com/Goby56/wakes/assets/80133652/41c020e5-dc2e-475c-91f4-eaf2c28d199b

I'm running Minecraft 1.20.1. Quilt loader.

@Rhett008
Copy link

Rhett008 commented Apr 8, 2024

Does downgrading to Wakes 0.2.2 fix it for you @Rhett008 with MakeUp Ultrafast on?

  • Downgrading fixes the see-through bug
  • But I get dark/black plane effects now when using my shaders (this is a shader thing - where the render of the effects are completely transparent)
  • Also I don't get wakes from underwater (obviously not in this version) which was nice

Please test out the latest test build and read the instructions in the release notes. (You will have to enable a setting in the config menu)

  • Yes, this also fixes the see-through bug
  • I get dark/black splash effects when using the shaders (this is a shader thing - where the render of the effects are completely transparent)
  • I now can't see underwater wakes when using shaders, when the debug option is enabled

2024-04-09_09 46 30

@Polarjd
Copy link

Polarjd commented Apr 10, 2024

Enabling depth test in the test build fixed the occlusion issue, but caused the effect to disappear at high camera angles. I am however using a dev build of bliss, and this only seems to happen with shaders and depth check on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.