Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wakes don't appear #9

Closed
nunes134 opened this issue Jul 13, 2023 · 32 comments
Closed

Wakes don't appear #9

nunes134 opened this issue Jul 13, 2023 · 32 comments
Labels
bug Something isn't working

Comments

@nunes134
Copy link

I installed all the dependencies, i did everything correct, and the wakes won't appear, the splashes work but the wakes don't.

Example:

8mb.video-Acv-bAtDMLNv.mp4
@Goby56
Copy link
Owner

Goby56 commented Jul 14, 2023

And you have not changed any of the configs? There are options to turn off wakes with YACL. They are, however, of course on by default. Other than that I can't really do anything more with the information you provided. A version number of the mod and additional logs would help figure out what is happening.

@nunes134
Copy link
Author

The version used was the Wakes 0.1.6, i reseted the config and nothing changed. What exactly about the logs would you need?

@Goby56
Copy link
Owner

Goby56 commented Jul 14, 2023

I don't know exactly what is happening in your case but currently theres a bug where wakes don't show for other players. Your case may be related to this.

One thing you could do is turn on debug boxes in the configs and see if they appear or if even they're invisible.

@nunes134
Copy link
Author

The debug boxes work fine

debugboxes.mp4

@Goby56
Copy link
Owner

Goby56 commented Jul 15, 2023

In that case it shows that the wakes do spawn. The reason for them not showing however could be for two reasons: either the actual simulation of the waves has not started or there's something wrong with the rendering.

I have a theory of what the problem could be but for the next week I'm unavailable and a fix will unfortunately have to wait.

@Goby56 Goby56 added the bug Something isn't working label Jul 16, 2023
@FantaC4t
Copy link

Would you know what possibly causes the waves to actually not render?
i have same issue as OP and the debug shows the same waves when i swim

@papamaionise
Copy link

I have the same issue

@Goby56
Copy link
Owner

Goby56 commented Jul 23, 2023

Please try the latest version (0.1.7) and see if the issue still presists

@FantaC4t
Copy link

Seems to work now, cheers mate thanks for making an amazing mod!

@Goby56 Goby56 closed this as completed Jul 23, 2023
@chrisdelmoro
Copy link

Hey Goby! The wakes are apearing for me as well now, but they are black and tones of dark grey intead of how you show them on the videos. Is this as simple as changing the colors on mod menu? If so can you tell the values I'm supoused to use?
20230723205651_1

@papamaionise
Copy link

@Goby56 Issue persists for me even with 0.1.7 version debug boxes appear but wakes don't
Here are the mods I'm using.
Screenshot (786)

@Goby56 Goby56 reopened this Jul 24, 2023
@Goby56
Copy link
Owner

Goby56 commented Jul 24, 2023

@chrisdelmoro send me your config file for the mod

@papamaionise
Copy link

wakes.txt
It was a .json file I converted to txt because it wasn't letting me upload I hope that doesn't changes anything.

@chrisdelmoro
Copy link

@chrisdelmoro send me your config file for the mod

wakes.txt

This is my wakes.json file. I had to convert it to .txt because github don't allow .json files here.
I didn't configure anything in your mod yet. I had installed it a few weeks ago and it never worked, so I just forgot about it. Your latest update was the first that did something for me. If the wakes.json file was not the configs you wanted, just mention me again with what file you need.

@Goby56
Copy link
Owner

Goby56 commented Jul 24, 2023

Thanks for your config files. I see nothing wrong with them.

As for your case @chrisdelmoro I've noticed that same issue when using shaders. Are anyone of you using shaders by any chance? If so, what shaders?

@chrisdelmoro
Copy link

Thanks for your config files. I see nothing wrong with them.

As for your case @chrisdelmoro I've noticed that same issue when using shaders. Are anyone of you using shaders by any chance? If so, what shaders?

It's my first time using fabric and it's ecosystem. I'm just using sodium, indium and the basic mods people say to use with fabric. I do have Iris Shaders but haven't fiddled with it yet.

@FantaC4t
Copy link

Thanks for your config files. I see nothing wrong with them.

As for your case @chrisdelmoro I've noticed that same issue when using shaders. Are anyone of you using shaders by any chance? If so, what shaders?

not using any shaders, wakes for some reason are also black for me now, even though yesterday they were fine. the config is the default config and i am not sure i added any mods since yesterday.
for some reason the .5 version is the one that worked the best for me for now

@Goby56
Copy link
Owner

Goby56 commented Jul 24, 2023

It's my first time using fabric and it's ecosystem. I'm just using sodium, indium and the basic mods people say to use with fabric. I do have Iris Shaders but haven't fiddled with it yet.

Hmm alright. I don't really know then what the issue could be. One last thing to try would be to change the wake style in the configs. Either change it through YACL to "Vibrant" or change the field "blend_mode" to "SCREEN" inside the config file wakes.json.
wake style

@Goby56
Copy link
Owner

Goby56 commented Jul 24, 2023

not using any shaders, wakes for some reason are also black for me now, even though yesterday they were fine. the config is the default config and i am not sure i added any mods since yesterday. for some reason the .5 version is the one that worked the best for me for now

That is really weird. Are you sure you haven't changed anything?

@FantaC4t
Copy link

not using any shaders, wakes for some reason are also black for me now, even though yesterday they were fine. the config is the default config and i am not sure i added any mods since yesterday. for some reason the .5 version is the one that worked the best for me for now

That is really weird. Are you sure you haven't changed anything?

after trying a clean install and only adding iris, sodium, mod menu, yacl, and wakes the issue still presists, weird, so far i have noticed that version 0.1.5 works the best so far.

@chrisdelmoro
Copy link

It's my first time using fabric and it's ecosystem. I'm just using sodium, indium and the basic mods people say to use with fabric. I do have Iris Shaders but haven't fiddled with it yet.

Hmm alright. I don't really know then what the issue could be. One last thing to try would be to change the wake style in the configs. Either change it through YACL to "Vibrant" or change the field "blend_mode" to "SCREEN" inside the config file wakes.json. wake style

I have no idea what solved the problem to me. Initialy I changed blend_mode to screen on the .json file as you said and it appeared to have solved the problem. Just to make sure that was the problem, I changed back to default and it is still working somehow..
I seems like an inconsistent problem..

@nunes134
Copy link
Author

The Vibrant Wakes for me don't appear, like it was on 0.1.6, but the wakes on Subtle appear black
I changed the field "blend_mode" to "SCREEN" and nothing changed

@papamaionise
Copy link

Thanks for your config files. I see nothing wrong with them.

As for your case @chrisdelmoro I've noticed that same issue when using shaders. Are anyone of you using shaders by any chance? If so, what shaders?

I am using no shaders but I am using indium.

@realstatis101
Copy link

Hey Goby! The wakes are apearing for me as well now, but they are black and tones of dark grey intead of how you show them on the videos. Is this as simple as changing the colors on mod menu? If so can you tell the values I'm supoused to use? 20230723205651_1

I too am having this issue, the 0.1.5 version works fine, 0.1.6 showed nothing, now 0.1.7 I can see the wakes but they're black, putting the "VIBRANT" setting on causes them to disappear like in 0.1.6 and putting "blend_mode" to "SCREEN" changed nothing

@papamaionise
Copy link

@Goby56 version 0.1.5 works perfectly with all those mods the problem is with mod version 0.1.6 and 0.1.7

@Goby56
Copy link
Owner

Goby56 commented Jul 31, 2023

The latest version (0.1.8) brings a new approach to lighting which can potentially fix the issue.

@papamaionise
Copy link

The latest version (0.1.8) brings a new approach to lighting which can potentially fix the issue.

yeah it solved the issue for me

@papamaionise
Copy link

The latest version (0.1.8) brings a new approach to lighting which can potentially fix the issue.

it sometimes crashes though when I'm generating too much wakes

crash-2023-08-01_00.39.49-client.txt

@papamaionise
Copy link

The latest version (0.1.8) brings a new approach to lighting which can potentially fix the issue.

ok the crash is pretty random actually

@Goby56
Copy link
Owner

Goby56 commented Jul 31, 2023

Ok, nice that they finally show.

These crashes, however, is a far bigger mystery for me. They are related to issue #1 and started to occur in this latest version. I thought I had eliminated them but I will try to fix this as soon as possible. For future crashes similar to the one you got refer to issue #1.

@Goby56 Goby56 closed this as completed Jul 31, 2023
@papamaionise
Copy link

Ok, nice that they finally show.

These crashes, however, is a far bigger mystery for me. They are related to issue #1 and started to occur in this latest version. I thought I had eliminated them but I will try to fix this as soon as possible. For future crashes similar to the one you got refer to issue #1.

ok Thank You goby

@realstatis101
Copy link

Great, works now, thank you, congrates on the great mod 👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants