Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Glitch When Certain Themes Are Applied #113

Open
OleExploder opened this issue Dec 22, 2023 · 14 comments
Open

Tabs Glitch When Certain Themes Are Applied #113

OleExploder opened this issue Dec 22, 2023 · 14 comments
Labels
bug Something isn't working

Comments

@OleExploder
Copy link

Whenever I apply certain themes, the color in the active tab glitches out and does not match with the rest of the theme's color.
Screenshot 2023-12-22 010146

@Godiesc
Copy link
Owner

Godiesc commented Dec 22, 2023

hi,
you should read the patch notes of this new version of the theme, I said that "tab-shapes" config can't align the selected-tab background with the background behind; sadly this seems to be unsolvable.

@Godiesc Godiesc added the bug Something isn't working label Dec 22, 2023
@OleExploder
Copy link
Author

Ok, thank you.

@Godiesc
Copy link
Owner

Godiesc commented Jan 5, 2024

This bug will solve in the next release of the theme, I was able to solve it.

@Godiesc Godiesc reopened this Jan 5, 2024
@OleExploder
Copy link
Author

That's cool, thank you!

@Godiesc
Copy link
Owner

Godiesc commented Jan 7, 2024

@OleExploder A new release of the theme was made, can you test it to see if all works fine?

@Godiesc Godiesc closed this as completed Jan 8, 2024
@OleExploder
Copy link
Author

I am sorry for the late reply but I tested it and everything looks better from what I have seen. Btw, are the tabs supposed to be opaque unlike the address bar?
Screenshot 2024-01-10 184629

I also want to note that a similar issue still happens when dragging a tab as well.

@Godiesc
Copy link
Owner

Godiesc commented Jan 10, 2024

when "dragging a tab" is a unsolvable bug, but the theme should looks well in the selected tab, I notice some themes with images can't align the image, I don't know why. other themes looks right like this:
https://addons.mozilla.org/es/firefox/addon/geometric-fury/

@OleExploder
Copy link
Author

I see, thanks.

@Godiesc
Copy link
Owner

Godiesc commented Jan 12, 2024

I was working on solution and seems I find out, I added this code, you can added for now in ogx_tricks.css:

  :root:is([lwtheme-image]){
  --lwt-background-alignment: right top !important;
  }

This solution will be include in the next release of the theme.

@Godiesc Godiesc reopened this Jan 12, 2024
@OleExploder
Copy link
Author

I tried adding that but nothing seemed to change and I could've done that wrong by using Notepad but I am not sure.

@Godiesc
Copy link
Owner

Godiesc commented Jan 13, 2024

All themes seems fine for me with that fix:

imagen

imagen

imagen

@OleExploder
Copy link
Author

OleExploder commented Jan 13, 2024

Looking at it again, same thing actually using one of the themes you listed in your comment so I think it might've worked but some themes still actually have the tab itself in a different color compared to the address bar such as this theme and dragging the tab looks the same even with that fix but I think it would be hard to fix like you said.

@Godiesc
Copy link
Owner

Godiesc commented Jan 13, 2024

It seems that themes that use transparencies in its images will have that problem, that theme you share use a svg image that just put the lines on repeat but the blue color is not part of the image, is part of the --frame color, that is why the problem appear. That That will become a permanent issue, I will add that info to the page. Thanks for your report.

@OleExploder
Copy link
Author

You're welcome and thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants