Timers

[RicardRC]

No description provided.

[AndreaCatania]

I'm really happy about this already, there are only some minor things to change.

As you already said in chat we are abusing a bit too much with the find and we should find an alternative solution.

As first thing I would add the function is_active_timer so you can use that function to check if a TimerHandle is valid and active. Then I would implement that function as follow:

bool TimerDatabag::is_active_timer(TimerHandle p_handle) {
    return timers.size() < p_handle ? timers[p_handle] < UINT64_MAX : false;
}

[AndreaCatania]

I forgot to mention that a better place for the TimerDatabag is this directory: https://github.com/GodotECS/godex/tree/main/modules/godot/databags

and you should register the databag here: https://github.com/GodotECS/godex/blob/main/modules/godot/register_types.cpp#L79-L94 to make it available.

[AndreaCatania]

The CI failed because the correct way to define the type def should be something like:

namespace godex {
typedef uint64_t Timer; // μs (microseconds) until the timer fires
typedef uint32_t TimerHandle;
};

[RicardRC]

I've still got to use the is_active_timer , but its in. I'll use it when we finish defining what to do with the destroyed timers vector, to polish up the logic.

[RicardRC]

Sorry for the force push(es)! Compressed all history, was quite messy, and rebased (makes my end of development easier).

[AndreaCatania]

Do force push on PR branches is totally fine

[AndreaCatania]

Nice we are getting there :) there are only few small things to address.

However, I think we should also add the System that updates now in the DataBag. We can talk about it in chat if you need help with that, or with the registration process.

[AndreaCatania]

Great work!!