Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkMessagesSessionRequest event expects a long argument instead of a ulong #448

Open
Avantir-Chaosfire opened this issue May 22, 2024 · 5 comments
Assignees
Labels
c-sharp Related to that Dot Net stuff

Comments

@Avantir-Chaosfire
Copy link

Avantir-Chaosfire commented May 22, 2024

Describe the bug
Using the .NET 6 version of GodotSteam, the NetworkMessagesSessionRequest is expecting a method with a long argument, but the value is a Steam ID, which should be a ulong. This means the data is corrupted and can't be used, rendering the event useless.

To Reproduce
In a C# project, hook up a method to the NetworkMessagesSessionRequest event. Notice that the argument type has to be long.

Expected behavior
The NetworkMessagesSessionRequest should expect and pass a ulong argument.

Screenshots
Screenshot 2024-05-22 at 11 05 16 AM

Desktop (please complete the following information):

  • OS: macOS 14.5

Version of Godot:
4.2.2

Version of GodotSteam:
4.8, module

Additional context
Steamworks 159

@Gramps Gramps self-assigned this May 22, 2024
@Gramps Gramps added the c-sharp Related to that Dot Net stuff label May 22, 2024
@Gramps
Copy link
Member

Gramps commented May 22, 2024

Hey there! We don't technically support C# currently or, more specifically, have no C# enabled stuff. How did you get the C# stuff working?

@Avantir-Chaosfire
Copy link
Author

@Gramps Oh - I didn't realize. I just did a custom build of Godot with GodotSteam. The glue generated fine (aside from this issue). I haven't run the project yet, I'm still busy converting it to Godot 4 & fixing compilation errors.

@Gramps
Copy link
Member

Gramps commented May 22, 2024

Oh, very cool! Have you checked out: https://github.com/LauraWebdev/GodotSteam_CSharpBindings These we made specifically for GodotSteam and may help.

@Avantir-Chaosfire
Copy link
Author

@Gramps Yes, that worked! (well, for the build. It will take some time to establish if it works at runtime...) Also interestingly, when I generated the glue for GodotSteam, it generated with a string identityReference in Godot 3 and a ulong steamId in Godot 4 (for the P2P networking APIs). But that project you linked swapped it back to string identityReference in Godot 4. So I'll stick with that for now.

@Gramps
Copy link
Member

Gramps commented May 27, 2024

Hmm, seems the string stuff is still in there then. It got changed recently so Laura may not have updated it for that then. Might want to put in an issue about it. Thanks for letting me know about all this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-sharp Related to that Dot Net stuff
Projects
None yet
Development

No branches or pull requests

2 participants