Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compile instructions in the Readme #14

Open
2 tasks done
pwab opened this issue May 4, 2020 · 3 comments
Open
2 tasks done

Improve compile instructions in the Readme #14

pwab opened this issue May 4, 2020 · 3 comments

Comments

@pwab
Copy link

pwab commented May 4, 2020

The precompiled version in this repository have been compiled with Visual Studio 2019 and using the Oculus SDK 1.43.0

@pwab pwab changed the title Oculus SDK mentioned in the Readme Improve compile instructions in the Readme May 4, 2020
@BastiaanOlij
Copy link
Member

Thanks for that, just pushed changes to the readme directly into master. Let me know if the wording makes sense.

@pwab
Copy link
Author

pwab commented May 5, 2020

Just another point:
With

Make sure submodules have been downloaded.

you mean that godot-cpp is downloaded as well? I was confused about this sentence at first and I did the mistake of downloading the repository from github web instead of cloning it cleanly with git. Only then the submodules are downloaded automatically.

This is just some wording problem. I wasn't sure which submodules you mean and how I have to download them.

@BastiaanOlij
Copy link
Member

Yup, you can always do a:

git submodule init
git submodule update

to fix it if you have git installed. It's annoying that github doesn't package the submodules when you just download the zip file. Especially seeing godot-cpp included godot-headers as a submodule so you need to do this stuff recursively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants