Color selector and Add Tile Wizard are not translatable

[amtriathlon]

This was reported at the forum, translations are present, but they are not being used:

I confirmed this using Spanish translation, I need to investigate the cause.

[amtriathlon]

The non translatable colors problem is due to setupColors being called before translation is enabled in main.cpp:

GoldenCheetah/src/Core/main.cpp

Line 441 in 5b838b4

// set default colors

GoldenCheetah/src/Core/main.cpp

Line 622 in 5b838b4

// install QT Translator to enable QT Dialogs translation

[amtriathlon]

The non translatable tile name and description is likely due to the use of a static function which is also called before QT translator is enabled:

GoldenCheetah/src/Charts/OverviewItems.cpp

Line 51 in 2554e03

static bool _registerItems()

[amtriathlon]

The way we solved the same problem in similar cases s.t. metrics registry is to call an initialize method after the translator is enabled:

GoldenCheetah/src/Core/main.cpp

Line 640 in 5b838b4

// Initialize metrics once the translator is installed

[amtriathlon]

For the Overview tiles I propose to make _registerItems a static member of OverviewItemConfig and call it from main, after the translator is enabled, it is a simple change, and it works.

WRT to colors, I am not sure about to move the call to setupColors due to the interdependence with the call to appsettings->migrateQSettingsSystem() documented in the code, even when this may not be needed anymore I would prefer not to take the risk, the easiest fix would be to call GCColor::setupColors() again once the translator is enabled to load the translated names, since this function only initializes static arrays it would be fast and safe.

[liversedge]

I would not worry too much about elegance since this is a fairly static piece of the codebase. Simple is usually best :)