Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedbacks #1

Open
tranquangvu opened this issue Apr 17, 2023 · 1 comment
Open

Feedbacks #1

tranquangvu opened this issue Apr 17, 2023 · 1 comment

Comments

@tranquangvu
Copy link

tranquangvu commented Apr 17, 2023

Please help to add these requirement:

- Remove movies module.
- Rename api_crud to app or api.
- Use postgresql engenie for database config.
- Allow set database config by ENVs.
- Add .env.example for all ENVs used in the template.
- password2 should be password_confirmation (my opinion: don't really need password_conformation in api side, it can be handle from client side).
- url /auth/token should be /auth/login.
- Add python linter.
- Allow to custom jwt secret, expire time from ENV.
- Add test for auth module.
- Add api document with swagger.
- Allow to run background task.
- Do we have any other required package for production? If have, please add them!

@joe-nghiem-goldenowl
Copy link
Collaborator

Hi @tranquangvu , I updated it. Can you review again, please ? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants