Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleos: add declarenames action to tx where names was resolved #192

Closed
3 tasks done
zxcat opened this issue Jan 16, 2019 · 1 comment
Closed
3 tasks done

Cleos: add declarenames action to tx where names was resolved #192

zxcat opened this issue Jan 16, 2019 · 1 comment
Assignees
@zxcat
Milestone
Sprint-jan-14

Comments

@zxcat
Copy link

zxcat commented Jan 16, 2019 •
edited

  • Add cyber.domain::declarenames action if at least one name was resolved in push action
  • Add option to disable declarenames adding
  • Must check that cyber.domain contract currently exists and contains declarenames action
@zxcat zxcat added this to the Sprint-jan-14 milestone Jan 16, 2019
@zxcat zxcat self-assigned this Jan 16, 2019
@zxcat zxcat mentioned this issue Jan 16, 2019
Closed
1 task
zxcat added a commit that referenced this issue Jan 17, 2019
@zxcat
Add to cleos ability to declare resolved names #192
68ad128 
1. cleos now auto-adds `declarenames` action with resolved names
    + this can be disabled with `--dont-declare-names` flag
    + this only happens if at least 1 name was resolved and `cyber.domain` contract exists and provides `declarename` action
2. When building transaction, then allow `bandwidth_provider` only if there are no signatures. Same with `declarenames`
3. `abi_domain_resolver` now contains default `unpack` too because of abi cache
4. Resolved names are now cached if there several `variant_to_abi` calls
5. Names resolving is now multi-pass to be ready if api returns not all names due timeout
6. Move `fc` to master
@zxcat
Copy link
Author

zxcat commented Jan 17, 2019

PR #204

afalaleev added a commit that referenced this issue Jan 17, 2019
@afalaleev
Merge pull request #204 from GolosChain/192-cleos-declarenames
1d95727 
Add to cleos ability to declare resolved names #192
@zxcat zxcat closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
None yet
Projects
None yet
Milestone
Sprint-jan-14
Development

No branches or pull requests
1 participant
@zxcat