Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cleos declare_names logic to notify user if can't declare #211

Closed
zxcat opened this issue Jan 18, 2019 · 1 comment
Closed

Change cleos declare_names logic to notify user if can't declare #211

zxcat opened this issue Jan 18, 2019 · 1 comment
Assignees
@zxcat
Milestone
Sprint-jan-14

Comments

@zxcat
Copy link

zxcat commented Jan 18, 2019

Current implementation of declaring names in cleos silently skips declaration there is no cyber.domain contract deployed. This can be unexpected to user, which want to declare used domain names / usernames.

Change logic to clearly notify user if names can't be declared, so he can decide if he want to skip declaration or deploy cyber.domain contract
@zxcat zxcat added this to the Sprint-jan-14 milestone Jan 18, 2019
@zxcat zxcat self-assigned this Jan 18, 2019
zxcat added a commit that referenced this issue Jan 22, 2019
@zxcat
Change cleos resolved names declaration to avoid silent skip #211
97d00cf
@zxcat
Copy link
Author

zxcat commented Jan 22, 2019

PR #230

afalaleev added a commit that referenced this issue Jan 23, 2019
@afalaleev
Merge pull request #230 from GolosChain/211-fix-cleos-declarenames
be75d6f 
Change cleos resolved names declaration to avoid silent skip #211
@zxcat zxcat closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
None yet
Projects
None yet
Milestone
Sprint-jan-14
Development

No branches or pull requests
1 participant
@zxcat