Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link internal domain actions with cyber.domain contract #232

Closed
zxcat opened this issue Jan 23, 2019 · 1 comment
Closed

Link internal domain actions with cyber.domain contract #232

zxcat opened this issue Jan 23, 2019 · 1 comment
Assignees
@zxcat
Milestone
Sprint-jan-28

Comments

@zxcat
Copy link

zxcat commented Jan 23, 2019

Current implementation of internal domain actions uses eosio as base contract like other internal actions (newaccount, etc…): https://github.com/GolosChain/cyberway/blob/ab53cfe307edb1f51aa7c5986329d9d2c347feb1/libraries/chain/controller.cpp#L240-L245
It's better to "link" them to cyber.domain contract to have additional limitations (like contract-provided restrictions for newdomain) in the same contract. Now newdomain from cyber.domain don't called when creating new domain via system action
@zxcat zxcat added this to the Sprint-jan-14 milestone Jan 23, 2019
@zxcat zxcat self-assigned this Jan 23, 2019
zxcat added a commit that referenced this issue Jan 27, 2019
@zxcat
Move internal domain actions to cyber.domain #232
5bc459b 
1. Five internal domain actions (`newusername`, `newdomain`, `passdomain`, `linkdomain`, `unlinkdomain`) moved to `cyber.domain` contract (was in `eosio`)
2. Domain contract account name (`cyber.domain`) added to config
3. `cyber.domain` account is now created at `initialize_database` to add abi, so internal actions can be used
4. cleos now gets domain contract name from config instead of hardcoded value
@zxcat
Copy link
Author

zxcat commented Jan 27, 2019

PR #247

@zxcat zxcat added WIP and removed WIP labels Jan 28, 2019
zxcat added a commit that referenced this issue Jan 29, 2019
@zxcat
Fix domain composite index + check existence before insert #232
c298619
afalaleev added a commit that referenced this issue Jan 30, 2019
@afalaleev
Merge pull request #247 from GolosChain/232-move-domain-actions
0a6a2b8 
Move internal domain actions to cyber.domain #232
@zxcat zxcat closed this as completed Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
None yet
Projects
None yet
Milestone
Sprint-jan-28
Development

No branches or pull requests
2 participants
@zxcat @s-medvedev