Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix names generation of genesis accounts #527

Closed
zxcat opened this issue Apr 17, 2019 · 1 comment
Closed

Fix names generation of genesis accounts #527

zxcat opened this issue Apr 17, 2019 · 1 comment
Assignees
@zxcat
Milestone
Sprint-apr-22

Comments

@zxcat
Copy link

zxcat commented Apr 17, 2019

Account names generated for genesis should not contain dots.
Current implementation doesn't respect this: https://github.com/GolosChain/cyberway/blob/c83e2bdabdacbb2520d6367db3f077d5a6477ae2/programs/create-genesis/genesis_create.cpp#L1000-L1005
@zxcat zxcat self-assigned this Apr 17, 2019
@s-medvedev s-medvedev added this to the Sprint-apr-22 milestone Apr 22, 2019
zxcat added a commit that referenced this issue May 8, 2019
@zxcat
Better account_names generation + split genesis-create #527
b648b82 
+ generate account names with sha1 and ensure there are no dots
+ move state reading code and constants to separate files
+ rename stake-related structs in abi to conform other names (some, like `param_struct` were too general)
+ improve golos_state accounts converting: there are several paths, how account_names derived from account object/account index/account id. unified helper functions used now instead of random chunks of code
+ enable serializer for system abi too
+ remove obsolete get_type_name helpers
+ remove some debug logs
@zxcat
Copy link
Author

zxcat commented May 8, 2019

PR #632

afalaleev added a commit that referenced this issue May 10, 2019
@afalaleev
Merge pull request #632 from GolosChain/527-genesis-generate-names
9379882 
Better account_names generation + split genesis-create #527
@zxcat zxcat closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
None yet
Projects
None yet
Milestone
Sprint-apr-22
Development

No branches or pull requests
2 participants
@zxcat @s-medvedev