Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail with "overflow" when deleting deferred tx from genesis #691

Closed
zxcat opened this issue May 17, 2019 · 0 comments
Closed

Fail with "overflow" when deleting deferred tx from genesis #691

zxcat opened this issue May 17, 2019 · 0 comments
Assignees
@afalaleev
Labels
bug Something isn't working
Milestone
Sprint-may-14

Comments

@zxcat
Copy link

zxcat commented May 17, 2019

STR

  1. Start node with genesis containing deferred transactions. Looks like transactions should not be expired.
  2. Wait for the start of blocks generation

Expected result

Deferred transactions applying and/or deleting from db

Actual results

nodeos crashes

Details

  1. The first issue is here:
    https://github.com/GolosChain/cyberway/blob/510d0df264ac365e257c8d8354a556726ad44549/libraries/chain/include/eosio/chain/resource_limits_private.hpp#L63
    looks like negative value ("freeing" ram) do not handled properly (there is remove_scheduled_transaction on stack)
  • Added neg || to the assert.
  1. Now it fails with EXC_BAD_ACCESS (code=1, address=0x48), callstack is:
    callstack
@zxcat zxcat added the bug Something isn't working label May 17, 2019
@zxcat zxcat added this to the Sprint-may-14 milestone May 17, 2019
@afalaleev afalaleev self-assigned this May 19, 2019
afalaleev added a commit that referenced this issue May 19, 2019
@afalaleev
Fix calculating of ram_usage by cache_map. #691
c2c8498
afalaleev added a commit that referenced this issue May 19, 2019
@afalaleev
Don't validate negative resource usage. #691
f00c438
afalaleev added a commit that referenced this issue May 19, 2019
@afalaleev
Fix initialize of resource accummulators in create-genesis. #691
dba8557
afalaleev added a commit that referenced this issue May 19, 2019
@afalaleev
Add ram_size to resource_limits_state_object. #691
a73b6ba
afalaleev added a commit that referenced this issue May 19, 2019
@afalaleev
Fix calculating of ram_usage by cache_map. #691
daac510
This was referenced May 19, 2019
Merged
Merged
afalaleev added a commit that referenced this issue May 19, 2019
@afalaleev
Merge pull request #694 from GolosChain/691-fix-overflow
cd937c9 
Fix overflow #691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afalaleev afalaleev

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint-may-14
Development

No branches or pull requests
2 participants
@zxcat @afalaleev