Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesis posts don't reward authors/curators #703

Closed
zxcat opened this issue May 20, 2019 · 3 comments
Closed

Genesis posts don't reward authors/curators #703

zxcat opened this issue May 20, 2019 · 3 comments
Assignees
@zxcat
Labels
bug Something isn't working
Milestone
Sprint-may-14

Comments

@zxcat
Copy link

zxcat commented May 20, 2019 •
edited

  1. Reward fund didn't change after closing all (but 1) genesis posts
  2. Last post didn't close (maybe related)

Looks like rewards info (rshares) or funds info is wrong
@zxcat zxcat added the bug Something isn't working label May 20, 2019
@zxcat zxcat added this to the Sprint-may-14 milestone May 20, 2019
@zxcat zxcat self-assigned this May 20, 2019
zxcat added a commit that referenced this issue May 22, 2019
@zxcat
Fix reading uint128 rshares in genesis #703
edbb5fe 
also minor cleanup
@zxcat
Copy link
Author

zxcat commented May 22, 2019

PR #725

afalaleev added a commit that referenced this issue May 22, 2019
@afalaleev
Merge pull request #725 from GolosChain/703-fix-genesis-rewards
3327377 
Fix reading uint128 rshares in genesis #703
@zxcat
Copy link
Author

zxcat commented May 22, 2019

Payments appeared after #725, something still wrong. rewardpools after closing all posts contains

{
  msgs: 6567,
  funds: "243746.984 GOLOS",
  rshares: "164462341000510599",
  rsharesfn: "164306541393007557"
}

and there are non-closed 6567 messages (failed transactions)

zxcat added a commit that referenced this issue May 23, 2019
@zxcat
Genesis: check rshares invariant + fix pool rshares #703
d42793d
zxcat added a commit that referenced this issue May 23, 2019
@zxcat
fix typo #703
c1323c3
@zxcat
Copy link
Author

zxcat commented May 23, 2019

PR #728

zxcat added a commit that referenced this issue May 24, 2019
@zxcat
Genesis: fix pool rshares + check rshares invariant #703 (#728)
961b783
@zxcat zxcat closed this as completed May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint-may-14
Development

No branches or pull requests
1 participant
@zxcat