Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vesting timeoutconv can erase wrong object #730

Closed
zxcat opened this issue Jun 21, 2019 · 1 comment
Closed

Vesting timeoutconv can erase wrong object #730

zxcat opened this issue Jun 21, 2019 · 1 comment
Assignees
@zxcat
Labels
bug Something isn't working
Milestone
Sprint-jun-24

Comments

@zxcat
Copy link
Contributor

zxcat commented Jun 21, 2019

it's possible to first move to the next object:
https://github.com/GolosChain/golos.contracts/blob/aaa75d7ced128ef99f331339f05d2760c1601836/golos.vesting/golos.vesting.cpp#L366
and then erase it instead current:
https://github.com/GolosChain/golos.contracts/blob/aaa75d7ced128ef99f331339f05d2760c1601836/golos.vesting/golos.vesting.cpp#L373

also code can modify record first and then erase it
@zxcat zxcat added the bug Something isn't working label Jun 21, 2019
@zxcat zxcat self-assigned this Jun 21, 2019
zxcat added a commit that referenced this issue Jun 24, 2019
@zxcat
Rewrite withdraw loop so all erase/inc in one place #730
d90e0a1
@zxcat zxcat added this to the Sprint-jun-24 milestone Jun 25, 2019
@zxcat
Copy link
Contributor Author

zxcat commented Jun 26, 2019

PR #736

zxcat added a commit that referenced this issue Jun 27, 2019
@zxcat
Rewrite withdraw loop so all erase/inc in one place #730
aab0b48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint-jun-24
Development

No branches or pull requests
2 participants
@zxcat @s-medvedev