Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reward_calcs_tester.limits_test #831

Closed
zxcat opened this issue Jul 21, 2019 · 1 comment
Closed

Fix reward_calcs_tester.limits_test #831

zxcat opened this issue Jul 21, 2019 · 1 comment
Assignees
@zxcat
Labels
bug Something isn't working
Milestone
Sprint-jul-22

Comments

@zxcat
Copy link
Contributor

zxcat commented Jul 21, 2019 •
edited

It fails after fixing voting charge in #832
@zxcat zxcat added the bug Something isn't working label Jul 21, 2019
zxcat added a commit that referenced this issue Jul 21, 2019
@zxcat
Fix voting battery price #829
7bb0212 
* fixes voting battery consumption
* adds rshares test to ensure given GESTS produce expected rshares and curator's weight (same as in Golos) (test added both to reward_calc and pure unit tests)
* disables limits_test #831
* adds new `posting_unit_tests.cpp` to contain pure unit tests which not depend on reward-calc model
* add some helpers to tests abi
@zxcat zxcat mentioned this issue Jul 21, 2019
Merged
zxcat added a commit that referenced this issue Jul 22, 2019
@zxcat
Fix voting battery price #829
bc6e689 
* fixes voting battery consumption
* adds rshares test to ensure given GESTS produce expected rshares and curator's weight (same as in Golos) (test added both to reward_calc and pure unit tests)
* disables limits_test #831
* adds new `posting_unit_tests.cpp` to contain pure unit tests which not depend on reward-calc model
* add some helpers to tests abi
@zxcat zxcat self-assigned this Jul 25, 2019
@zxcat zxcat added this to the Sprint-jul-22 milestone Jul 25, 2019
zxcat added a commit that referenced this issue Jul 25, 2019
@zxcat
Fix limits test & reduce delta thresholds #831,#836
7a1b415 
+ restore limits_test
+ unify functions in `golos_curation` to give same result when `x` is near to `0`
+ reduce delta thresholds (from 20% to 0.1% in some cases) and fix tests
+ some work to support charge in votes model
zxcat added a commit that referenced this issue Jul 25, 2019
@zxcat
Fix limits test & reduce delta thresholds #831,#836
08b227c 
+ restore limits_test
+ unify functions in `golos_curation` to give same result when `x` is near to `0`
+ reduce delta thresholds (from 20% to 0.1% in some cases) and fix tests
+ some work to support charge in votes model
zxcat added a commit that referenced this issue Jul 25, 2019
@zxcat
typo #831
a000dd1
@zxcat
Copy link
Contributor Author

zxcat commented Jul 25, 2019

PR #837

zxcat added a commit that referenced this issue Jul 26, 2019
@zxcat
Fix limits test & reduce delta thresholds #831,#836 (#837)
0b2b72b 
* Fix limits test & reduce delta thresholds #831,#836

+ restore limits_test
+ unify functions in `golos_curation` to give same result when `x` is near to `0`
+ reduce delta thresholds (from 20% to 0.1% in some cases) and fix tests
+ some work to support charge in votes model

* Fix voting charge usage in rewards calc test model #829
@zxcat zxcat closed this as completed Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint-jul-22
Development

No branches or pull requests
1 participant
@zxcat