Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable payment with vesting to use battery #835

Closed
zxcat opened this issue Jul 25, 2019 · 0 comments
Closed

Disable payment with vesting to use battery #835

zxcat opened this issue Jul 25, 2019 · 0 comments
Assignees
@zxcat
Milestone
Sprint-jul-22

Comments

@zxcat
Copy link
Contributor

zxcat commented Jul 25, 2019

not used now, will be enabled later, needs more testing
@zxcat zxcat added this to the Sprint-jul-22 milestone Jul 25, 2019
@zxcat zxcat self-assigned this Jul 25, 2019
zxcat added a commit that referenced this issue Jul 26, 2019
@zxcat
Disable vesting and storables in charge contract #835
f79b8ee 
Contracts:
+ Add 2 defines to charge contract to disable vesting and storables
+ charge `use` action now fails if non-zero `vesting_price` passed
+ charge `setrestorer` action now fails if function contains `"v"` variable
+ posting `createmssg` action now fails if `vestpayment==true`
+ posting `setlimit` action now fails if non-zero `vesting_price` or `min_vesting` passed
+ charge `useandstore` and `removestored` actions not used. their implementation removed if `DISABLE_CHARGE_STORABLE` defined. Note: actions and related tables still in abi (can't conditionally enable/disable)
+ minor fixes and optimizations

Tests:
+ Add 2 defines to charge test api to disable vesting and storables tests
+ add `disabled_vesting` charge test and `disabled_charge_vesting` publication test
+ fix tests which used vesting-powered charges (`limits_test` timeout set as workaround, it should be based on something to test properly)
zxcat added a commit that referenced this issue Jul 29, 2019
@zxcat
Disable vesting and storables in charge contract #835
6348664 
Contracts:
+ Add 2 defines to charge contract to disable vesting and storables
+ charge `use` action now fails if non-zero `vesting_price` passed
+ charge `setrestorer` action now fails if function contains `"v"` variable
+ posting `createmssg` action now fails if `vestpayment==true`
+ posting `setlimit` action now fails if non-zero `vesting_price` or `min_vesting` passed
+ charge `useandstore` and `removestored` actions not used. their implementation removed if `DISABLE_CHARGE_STORABLE` defined. Note: actions and related tables still in abi (can't conditionally enable/disable)
+ minor fixes and optimizations

Tests:
+ Add 2 defines to charge test api to disable vesting and storables tests
+ add `disabled_vesting` charge test and `disabled_charge_vesting` publication test
+ fix tests which used vesting-powered charges (`limits_test` timeout set as workaround, it should be based on something to test properly)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zxcat zxcat

Labels
None yet
Projects
None yet
Milestone
Sprint-jul-22
Development

No branches or pull requests
2 participants
@zxcat @s-medvedev