Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Object reference not set to an instance of an object #184

Open
jabberjabberjabber opened this issue Jan 9, 2024 · 0 comments
Open

Comments

@jabberjabberjabber
Copy link

jabberjabberjabber commented Jan 9, 2024

Running 12.9.1 using BeatUpClient connecting to a BeatUpServer instance.

An exception was thrown processing custom packet 'MpexPlayerData' from player '(...)': Object reference not set to an instance of an object
System.NullReferenceException: Object reference not set to an instance of an object
  at MultiplayerExtensions.Players.MpexPlayerManager.HandlePlayerData (MultiplayerExtensions.Players.MpexPlayerData packet, IConnectedPlayer player) [0x00014] in <0719e2db656940a8aaaba55860e2abbb>:0 
  at MultiplayerCore.Networking.MpPacketSerializer+<>c__DisplayClass12_0`1[TPacket].<RegisterCallback>b__1 (LiteNetLib.Utils.NetDataReader reader, System.Int32 size, IConnectedPlayer player) [0x00013] in <2a7a06274ca84b5fb1a6ae53e1f3abb1>:0 
  at MultiplayerCore.Networking.MpPacketSerializer.Deserialize (LiteNetLib.Utils.NetDataReader reader, System.Int32 length, IConnectedPlayer data) [0x0003a] in <2a7a06274ca84b5fb1a6ae53e1f3abb1>:0 

Talked to rcelyte since they are client creator, and they found the issue is with MultiplayerExtensions and made a patch:

diff --git a/MultiplayerExtensions/Players/MpexPlayerManager.cs b/MultiplayerExtensions/Players/MpexPlayerManager.cs
index c644fd1..c1a4b0e 100644
--- a/MultiplayerExtensions/Players/MpexPlayerManager.cs
+++ b/MultiplayerExtensions/Players/MpexPlayerManager.cs
@@ -52,7 +52,7 @@ namespace MultiplayerExtensions.Players
 		private void HandlePlayerData(MpexPlayerData packet, IConnectedPlayer player)
 		{
 			_playerData[player.userId] = packet;
-			PlayerConnectedEvent(player, packet);
+			PlayerConnectedEvent?.Invoke(player, packet);
 		}

 
 		public bool TryGetPlayer(string userId, out MpexPlayerData player)

I am running it as a test.

Thought you'd like to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant