Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0 and 1.6.1: webgl renderer's view isn't removed from its property list in destroy (). #984

Closed
agamemnus opened this issue Sep 20, 2014 · 5 comments

Comments

@agamemnus
Copy link
Contributor

Topic.

@agamemnus agamemnus changed the title 1.61: webgl renderer's view isn't removed from its property list in destroy (). 1.60 and 1.61: webgl renderer's view isn't removed from its property list in destroy (). Sep 20, 2014
@agamemnus agamemnus changed the title 1.60 and 1.61: webgl renderer's view isn't removed from its property list in destroy (). 1.6.0 and 1.6.1: webgl renderer's view isn't removed from its property list in destroy (). Sep 21, 2014
@GoodBoyDigital
Copy link
Member

Thanks for this @agamemnus but I am happy for that responsibility to sit with the user.

@agamemnus
Copy link
Contributor Author

I don't understand why you would want the renderer to maintain a reference to the view after it has been destroyed...?

@GoodBoyDigital
Copy link
Member

whoops I miss read what you meant! Did you submit a pr for this?

@agamemnus
Copy link
Contributor Author

I didn't.

It's tied into some other issues... like the default renderer thing -- if you are going to have a default renderer, it needs to be unset as a default renderer if it is in fact a default renderer and is destroyed...

Here is what my fork has for the = nulls part of the function:

this.gl = null;
this.renderSession = null;
this.view = null;
this.__stage = null;
this.contextRestoredLost = null;
this.stencilManager = null;
this.blendModeManager = null;
this.contextOptions = null;

@englercj englercj closed this as completed Jan 8, 2015
@lock
Copy link

lock bot commented Feb 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants