Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted to grunt build #46

Merged
merged 1 commit into from Apr 3, 2013
Merged

Converted to grunt build #46

merged 1 commit into from Apr 3, 2013

Conversation

CharlotteGore
Copy link

As suggested I've reduced the pull request so that it no longer includes rebuilt files, only the minimum required to do a build with grunt. Ant system removed. Docs updated.

@englercj
Copy link
Member

englercj commented Apr 3, 2013

Thats what I'm talking about 👍

@GoodBoyDigital
Copy link
Member

Nice one CharlotteGore! Thanks so much for converting the build files :D
You mentioned in the previously closed post about unit tests. I have to admit I have not made unit tests before.. Would love to hear any suggestions from you or anyone else regarding how to go about implementing them.

@englercj
Copy link
Member

englercj commented Apr 3, 2013

@GoodBoyDigital I lay in my vote for QUnit or Mocha, You can see how I am doing tests in grapefruit in my Gruntfile.js and in my test folder.

I would be happy to setup a framework and submit a PR

@GoodBoyDigital
Copy link
Member

Thanks very much @englercj that would be super helpful :)

@englercj
Copy link
Member

englercj commented Apr 3, 2013

@GoodBoyDigital No problem, as soon as this gets merged I will write something up.

GoodBoyDigital added a commit that referenced this pull request Apr 3, 2013
@GoodBoyDigital GoodBoyDigital merged commit 77bc786 into pixijs:master Apr 3, 2013
@lock
Copy link

lock bot commented Feb 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants