You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the creation of goodnative we've been seeing a lot of errors that aren't on master, most likely branches codebase merge didn't go as well as we thought. Hence we want to fix all eslint errors in hopes of reducing the amount of small errors such as missing vars, etc.
The text was updated successfully, but these errors were encountered:
@serdiukov-o-nordwhale I reviewed this and there're no eslint errors to fix, everything is ok. Are you sure we're having errors that eslint isn't catching?
The only changes I had to do in order to keep everything up-to-date is remove eslint-plugin-dependencies because of this zertosh/eslint-plugin-dependencies#21
I can merge those changes but please confirm if you still think we're having issues not fixed
Hmmm. If everything ok with eslint that we just have forgot to run it after merge with resolve conflicts. Need to run global lint fix in that case
Could you please also add some rules checking this context in the class methods? And re - check the whole app without it please. For now it will be enough
Description
Since the creation of goodnative we've been seeing a lot of errors that aren't on master, most likely branches codebase merge didn't go as well as we thought. Hence we want to fix all eslint errors in hopes of reducing the amount of small errors such as missing vars, etc.
The text was updated successfully, but these errors were encountered: