Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Chore) Fix all eslint errors in react-native branch #2564

Closed
mauriguz opened this issue Oct 9, 2020 · 3 comments
Closed

(Chore) Fix all eslint errors in react-native branch #2564

mauriguz opened this issue Oct 9, 2020 · 3 comments
Assignees
Milestone

Comments

@mauriguz
Copy link
Contributor

mauriguz commented Oct 9, 2020

Description

Since the creation of goodnative we've been seeing a lot of errors that aren't on master, most likely branches codebase merge didn't go as well as we thought. Hence we want to fix all eslint errors in hopes of reducing the amount of small errors such as missing vars, etc.

@mauriguz mauriguz self-assigned this Oct 9, 2020
@mauriguz
Copy link
Contributor Author

@serdiukov-o-nordwhale I reviewed this and there're no eslint errors to fix, everything is ok. Are you sure we're having errors that eslint isn't catching?
The only changes I had to do in order to keep everything up-to-date is remove eslint-plugin-dependencies because of this zertosh/eslint-plugin-dependencies#21

I can merge those changes but please confirm if you still think we're having issues not fixed

@serdiukov-o-nordwhale
Copy link
Contributor

Hmmm. If everything ok with eslint that we just have forgot to run it after merge with resolve conflicts. Need to run global lint fix in that case

Could you please also add some rules checking this context in the class methods? And re - check the whole app without it please. For now it will be enough

Thank you

@sirpy sirpy added this to the Phase2 milestone Oct 11, 2020
@mauriguz
Copy link
Contributor Author

fixes for current rules pushed to react-native. add of context rules for class methods moved to #1783
closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants