Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUEUE_ABOVE_PY_37 is Always False due to a Typo #4

Open
ender-s opened this issue Aug 25, 2023 · 0 comments · May be fixed by #5
Open

QUEUE_ABOVE_PY_37 is Always False due to a Typo #4

ender-s opened this issue Aug 25, 2023 · 0 comments · May be fixed by #5

Comments

@ender-s
Copy link

ender-s commented Aug 25, 2023

In ThreadPoolExecutorPlus/thread.py, there is the following assignment for the variable QUEUE_ABOVE_PY_37:
QUEUE_ABOVE_PY_37 = True if 'SipleQueue' in dir(queue) else False

Since there is no "SipleQueue" in the queue module, this expression always evaluates to False.
@ender-s ender-s linked a pull request Aug 25, 2023 that will close this issue
Open
@ender-s ender-s changed the title QUEUE_ABOVE_PY_37 is always False due to a Typo QUEUE_ABOVE_PY_37 is Always False due to a Typo Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: SipleQueue typo ender-s/ThreadPoolExecutorPlus
1 participant
@ender-s