fix(file rename): Overwrite original file rather than use Rename #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an 'invalid cross-device link' error when running inside docker
|
Thank you for the submission. I will take a look at it soon. The |
clok
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
@laneroberts-ul Looks good. I am going to merge this patch and then apply this to the 2 other locations where os.Rename is used. I have plans for a v2 refactor of the codebase that will DRY up the code and will hopefully result in a more extensible tool.
Thank you again for the contribution. I will tag this PR once the release is pushed.
clok
changed the title
|
@laneroberts-ul release has been pushed https://github.com/GoodwayGroup/gwvault/releases/tag/v1.8.1 |
|
@clok Thank you! Now I can re-simplify my pipelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When decrypting a file inside Docker, os.Rename() results in an 'invalid cross-device link' error. This is not an optimized solution, but fixed the issue I was having.
Resolves #20