Update clock dart packaged app example for a modern dart. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the clock to run in Dartium m31, or in Chrome, without changes. Changes: dart2js no longer accepts --disallow-unsafe-eval window.requestLayoutFrame is now scheudleMicrotask from dart:async. Date is now DateTime List<E>.filter is now List<E>.removeWhere String.charCodeAt is now String.codeUnitAt js/interop stuff no longer required Bugfix: Fix numbers not showing up at all when first opened, e.g., at exactly 4pm and now.minute == 0. Review URL: https://codereview.appspot.com/56440043
tapted
referenced
this pull request
in nelsonsilva/chrome-app-samples
Jan 28, 2014
benfredwells
added a commit
that referenced
this pull request
Apr 4, 2014
Update clock dart packaged app example for a modern dart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the clock to run in Dartium m31, or in Chrome,
without changes.
Changes:
dart2js no longer accepts --disallow-unsafe-eval
window.requestLayoutFrame is now scheudleMicrotask from dart:async.
Date is now DateTime
List.filter is now List.removeWhere
String.charCodeAt is now String.codeUnitAt
js/interop stuff no longer required
Bugfix: Fix numbers not showing up at all when first opened, e.g., at
exactly 4pm and now.minute == 0.
Review URL: https://codereview.appspot.com/56440043