Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article reference for integration Lighthouse CI #120

Merged
merged 2 commits into from Dec 7, 2019

Conversation

akanshgulati
Copy link
Contributor

The article explains exactly a use-case of Lighthouse CI for static site generators which can run a local server for serving files and test performance.

The article explains exactly a use-case of Lighthouse CI for static site generators which can run a local server for serving files and test performance.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@patrickhulce
Copy link
Collaborator

Thanks very much for the contribution @akanshgulati, great job on the article! 😃

I'm not sure how I feel about linking to what basically amounts to alternative documentation in "Related Projects" on the main readme though. There are a few suggestions in the article that skip past some of the disclaimers we were very careful about in the official documentation, so I'm nervous to give it such prominence as-is.

Proposal: Maybe we can work together to clear up a few of the discrepancies with the official docs in the post and add a "Community Guides" section for this sort of thing? :)

@akanshgulati
Copy link
Contributor Author

@patrickhulce I totally agree that it's not a project and should not be added under that section (missed by me while creating PR). I tried to explain a particular use-case where Lighthouse CI is being used for static website performance testing and as you said, this can be added under a "Community Guides" section instead.
Regarding the changes, I think it's best to keep the article in sync with Lighthouse CI team, please suggest changes.
Article source file - https://github.com/akanshgulati/personal-blog-gatsby-markdown/blob/master/src/posts/integrating-lighthouse-ci/integrate-lighthouse-ci.md

@patrickhulce
Copy link
Collaborator

OK @akanshgulati I opened a PR with some tweaks over there :)

@akanshgulati
Copy link
Contributor Author

akanshgulati commented Dec 6, 2019

Thanks very much for the contribution @akanshgulati, great job on the article! 😃

I'm not sure how I feel about linking to what basically amounts to alternative documentation in "Related Projects" on the main readme though. There are a few suggestions in the article that skip past some of the disclaimers we were very careful about in the official documentation, so I'm nervous to give it such prominence as-is.

Proposal: Maybe we can work together to clear up a few of the discrepancies with the official docs in the post and add a "Community Guides" section for this sort of thing? :)

@patrickhulce Time to add a new section 🥇

@akanshgulati
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

README.md Show resolved Hide resolved
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickhulce patrickhulce merged commit 3a2a928 into GoogleChrome:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants