New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add article reference for integration Lighthouse CI #120
Conversation
The article explains exactly a use-case of Lighthouse CI for static site generators which can run a local server for serving files and test performance.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks very much for the contribution @akanshgulati, great job on the article! 😃 I'm not sure how I feel about linking to what basically amounts to alternative documentation in "Related Projects" on the main readme though. There are a few suggestions in the article that skip past some of the disclaimers we were very careful about in the official documentation, so I'm nervous to give it such prominence as-is. Proposal: Maybe we can work together to clear up a few of the discrepancies with the official docs in the post and add a "Community Guides" section for this sort of thing? :) |
@patrickhulce I totally agree that it's not a project and should not be added under that section (missed by me while creating PR). I tried to explain a particular use-case where Lighthouse CI is being used for static website performance testing and as you said, this can be added under a "Community Guides" section instead. |
OK @akanshgulati I opened a PR with some tweaks over there :) |
@patrickhulce Time to add a new section 🥇 |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The article explains exactly a use-case of Lighthouse CI for static site generators which can run a local server for serving files and test performance.