feat(collect): Make it easy to use with SPA #159
Merged
+77
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: #157 |
Amagon96
reviewed
Dec 19, 2019
patrickhulce
requested changes
Dec 20, 2019
There was a problem hiding this comment.
Thanks very much for the PR @rdlabo! Implementation looks great 🎉
Would you mind adding a test case? Preferably we have two, one for ensuring a missing file 404's when the flag is missing and one for ensuring a missing file returns the index page when the flag is there.
It might be overkill to test the entire collect pipeline for this so feel free to create a new fallback-server.test.js file
|
@patrickhulce Thanks for review. I added simple test case for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can't set both
startServerCommandandstaticDistDir.ref: https://github.com/GoogleChrome/lighthouse-ci/blob/master/packages/cli/src/collect/collect.js#L100-L102
So server return 404 not found at sub-page in SPA.
I think
isSinglePageApplicationflag is very useful. (When using no SPA, 404 information is important)Thanks.
closes #157