Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module '@lhci/server/src/api/storage/storage-method.js' #247

Closed
trptcolin opened this issue Mar 19, 2020 · 5 comments
Closed
Labels
bug Something isn't working P0

Comments

@trptcolin
Copy link

trptcolin commented Mar 19, 2020

When running lhci healthcheck on the latest CLI version ("@lhci/cli": "0.3.10"), I get this error:

Cannot find module '@lhci/server/src/api/storage/storage-method.js'
Require stack:
- /PATH/REDACTED/node_modules/@lhci/cli/src/wizard/wizard.js
- /PATH/REDACTED/node_modules/@lhci/cli/src/cli.js

Things work fine in "@lhci/cli": "0.3.9"

I believe the issue is that #239 introduces a runtime dependency for @lhci/cli on the @lhci/server package, with no corresponding actual package.json dependency. This line specifically.

Workarounds that I can confirm are 👍 for me:

  • Explicitly add "@lhci/server": "0.3.10" as a dependency.
  • Downgrade to "@lhci/cli": "0.3.9"

I'm not sure whether the right fix is to explicitly add the server dependency, or to reconfigure things so it's not necessary, but wanted to at least file the workarounds for others who might hit this.

@patrickhulce
Copy link
Collaborator

Oof, thanks @trptcolin! We'll fix asap 👍

@NullVoxPopuli
Copy link

@patrickhulce patrickhulce added bug Something isn't working P0 labels Mar 19, 2020
@patrickhulce
Copy link
Collaborator

Published 0.3.11 that should fix this. Leaving this open while we figure out a test story that can test this situation better.

@trptcolin
Copy link
Author

Wow that was quick. Thanks!

@Ethan-Arrowood
Copy link

Can confirm 0.3.11 fixed my ci! thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0
Projects
None yet
Development

No branches or pull requests

4 participants