feat(server): add warnings when versions change #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
version_warnings
branch
from
937c570
to
81a8f49
Compare
| function metaLighthouseVersion() { | ||
| return lhrs => { | ||
| const version = lhrs[0].lighthouseVersion || ''; | ||
| const [_, major = '0', minor = '0', patch = '0'] = version.match(/^(\d+)\.(\d+)\.(\d+)/) || []; |
There was a problem hiding this comment.
do you care about the alpha/beta tag?
There was a problem hiding this comment.
not really. we'll never publish a version of lhci that's stuck on an alpha or beta tag and in the event that someone uploads data manually to lhci server using lighthouse@next I'm ok with the idea that they won't get warnings between alpha/beta/final versions
this behavior is also captured by the tests for this file so unlikely to accidentally change it either
|
super weird, this has already been merged not sure why it's open... there's even activity from the pull bot saying it's been pulled into forks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build comparisons will appear in the usual runtime settings warning modal
dashboard will appear as shaded background on the time delta between the two builds where the change occurred and have a warning in the build overlay with the gauge
ref #119