Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): tweaks, toc, reorder, global options #293

Merged
merged 3 commits into from May 2, 2020
Merged

Conversation

paulirish
Copy link
Member

okay as you suggested this'll be slightly easier by commit.

a few extra things

  • i added a TOC
  • the recopy with width 100 commit has a git diff --word-diff of this.
  • the Configuration section at the end is odd as it seems to duplicate what's already in the first paragraph under Commands and/or whats in the configuration.md.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great thanks! you'll have to manually restart the travis job for the flake. thanks to travis' recent "improvements" I don't even have that authority apparently 😡

or

```bash
yarn global add @lhci/cli
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 the original author here is gonna be so disappointed. they originally added duplicate copies of every single usage of npm and I talked them into this instead :)

@paulirish
Copy link
Member Author

CI is happy. i'll let you squash/merge

@patrickhulce patrickhulce merged commit 781d152 into master May 2, 2020
@patrickhulce patrickhulce deleted the docscli branch May 2, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants