Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable assertions of timing metrics through budgets file #377

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Enable assertions of timing metrics through budgets file #377

merged 1 commit into from
Jul 17, 2020

Conversation

jonaswalden
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jonaswalden jonaswalden changed the title added timing metrics to budget assertion converter Enable assertions of timing metrics through budgets file Jul 8, 2020
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @jonaswalden! great catch!

Would you be able to sign the CLA to make @googlebot happy? :)

@jonaswalden
Copy link
Contributor Author

jonaswalden commented Jul 8, 2020

No problem! Working on sorting out the CLA business. Awaiting legal approval, people on vacation and so forth ;D

@jonaswalden
Copy link
Contributor Author

@googlebot I signed it!

1 similar comment
@jonaswalden
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants