Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failure on merge-base #42

Closed
wants to merge 1 commit into from
Closed

fix failure on merge-base #42

wants to merge 1 commit into from

Conversation

paulirish
Copy link
Member

repro

mkdir blah
cd blah
git init
git remote add origin git@github.com:exterkamp/lighthouse-ci-action.git
git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress --no-recurse-submodules origin "+refs/heads/*:refs/remotes/origin/*"
git checkout --progress --force f2892d1121a20ba2ec047057e5351fdff7fa4905
git merge-base HEAD master
# fatal: Not a valid object name master

@patrickhulce
Copy link
Collaborator

it feels like we should have a chain of fallbacks for some of these functions because depending on how the repo was cloned nothing is going to work 100% of the time

@patrickhulce patrickhulce deleted the paulirish-patch-1 branch December 3, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants