Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #687: ensure history commit message easy to read #688

Merged
merged 4 commits into from Sep 13, 2021

Conversation

geoffreysamper
Copy link
Contributor

No description provided.

@@ -122,7 +121,6 @@
flex-grow: 1;
flex-shrink: 10;
text-overflow: ellipsis;
white-space: pre;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of deleting this line, let's just use nowrap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickhulce tested it with nowrap
image
tested it with wrap
image

I think the wrap is better but it your call

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nowrap was the intended design here, let's stick with that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to nowrap

@patrickhulce
Copy link
Collaborator

thanks very much @geoffreysamper !

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you!

@patrickhulce patrickhulce merged commit 3c1c4bf into GoogleChrome:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants