Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect 11ty's output dir as staticDistDir #895

Merged
merged 1 commit into from Apr 13, 2023

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Apr 8, 2023

Hey 馃憢馃徎

I was surprised when Lighthouse CI didn't detect my built page when setting up a new build. The error message was really helpful, so I got up and running quickly, but I figured I'd ask if you'd consider adding _site to the list of automatically detect staticDistDir directories.

I figured that it would be a low-risk change, since I suspect that there aren't many directories named _site in other systems.

Let me know what you think :)

References

https://www.11ty.dev/docs/config/#output-directory

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Yeah sounds great.

Thanks for the A+ PR

@paulirish paulirish changed the title detect 11ty default output dir as staticDistDir detect 11ty's output dir as staticDistDir Apr 13, 2023
@paulirish paulirish merged commit ebff823 into GoogleChrome:main Apr 13, 2023
4 checks passed
@koddsson koddsson deleted the patch-1 branch April 14, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants