Skip to content

Commit

Permalink
Clarification of hasOfflineStartUrl rule (#2775)
Browse files Browse the repository at this point in the history
* Clarification of hasOfflineStartUrl rule

Error message is confusing for some users (https://stackoverflow.com/questions/45330087/manifest-start-url-is-not-cached-by-a-service-worker) and technically it's not true. There's check if the start_url is returned, and if not the message that it's not cached is returned. There's possibility for service worker to cache it but not return it and receive this error message.

* Adjusted wording
  • Loading branch information
karolklp authored and paulirish committed Aug 14, 2017
1 parent 0455283 commit 7097d5c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lighthouse-core/audits/webapp-install-banner.js
Expand Up @@ -81,7 +81,7 @@ class WebappInstallBanner extends MultiCheckAudit {
const hasOfflineStartUrl = artifacts.StartUrl.statusCode === 200;

if (!hasOfflineStartUrl) {
result.failures.push('Manifest start_url is not cached by a service worker');
result.failures.push('Service worker does not successfully serve the manifest\'s start_url');
}

if (artifacts.StartUrl.debugString) {
Expand Down

0 comments on commit 7097d5c

Please sign in to comment.