Skip to content

Commit

Permalink
fix(report): proper arrow state and consistent capitalization (#2750)
Browse files Browse the repository at this point in the history
  • Loading branch information
patrickhulce authored and brendankenny committed Jul 26, 2017
1 parent 78ec647 commit 7c461bf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lighthouse-core/report/v2/renderer/category-renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ class CategoryRenderer {
*/
_renderAuditGroup(group, opts) {
const expandable = opts.expandable;
const element = this._dom.createElement(expandable ? 'details' :'div', 'lh-audit-group');
const element = this._dom.createElement(expandable ? 'details' : 'div', 'lh-audit-group');
const summmaryEl = this._dom.createChildOf(element, 'summary', 'lh-audit-group__summary');
const headerEl = this._dom.createChildOf(summmaryEl, 'div', 'lh-audit-group__header');
this._dom.createChildOf(summmaryEl, 'div',
Expand Down Expand Up @@ -338,7 +338,7 @@ class CategoryRenderer {
const nonPassedAudits = nonManualAudits.filter(audit => !passedAudits.includes(audit));

const nonPassedElem = this._renderAuditGroup({
title: `${nonPassedAudits.length} failed audits`,
title: `${nonPassedAudits.length} Failed Audits`,
}, {expandable: false});
nonPassedElem.classList.add('lh-failed-audits');
nonPassedAudits.forEach(audit => nonPassedElem.appendChild(this._renderAudit(audit)));
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/report/v2/report-styles.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7c461bf

Please sign in to comment.