Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI should warn if Node version < 5.x #105

Closed
paulirish opened this issue Mar 30, 2016 · 5 comments
Closed

CLI should warn if Node version < 5.x #105

paulirish opened this issue Mar 30, 2016 · 5 comments
Assignees

Comments

@paulirish
Copy link
Member

(orig reported at #73 )

Since we're using a bunch of es2015 features, node 4 isn't supported.

The cli should error and exit if you're not running using a 5.x runtime.

question: Should the error message recommend using nvm?

@paulirish
Copy link
Member Author

question: Should the error message recommend using nvm?

@gauntface sez:

I think a message to upgrade or use NVM if you need older node versions too is a safe bet

sg

@samccone
Copy link
Contributor

telling people what software to install gets really messy fast, we already know the CLI tool will be for a more "Experienced" dev, so I think just throwing a nice message saying <Lighthouse requires node 5.9..> will be more than enough.

@deepanjanroy
Copy link
Member

Is it ok to add in a dependency like https://www.npmjs.com/package/node-version-compare? In that case we can have a nice minVersion variable and change that in the future. Otherwise I can just look at the first/second char of the version string and make sure there's something >= 5 there.

@samccone
Copy link
Contributor

checkout the semver module. That is what we will want to use here ✨

@deepanjanroy
Copy link
Member

sweet thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants