-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align load-fast-enough-for-pwa with Core Web Vitals? #10943
Comments
Looks like the current "fast enough" is not based on the "good" threshold for TTI but rather on some lower value. In a perfect world I think we'd like to recommend "good" on all Core Web Vitals metrics, but that may be too restrictive for any PWA definition. Maybe we can say "good enough" means not getting "poor" on any Core Web Vitals metric? |
That limit is super old (#1840), so it probably is time to take another look (but an update would probably have to wait for a major version change). It's kind of unfortunate we didn't coordinate it with the checklist update when it moved to web.dev, though.
Right, the idea was to decouple the PWA definition from our speed recommendations. i.e. you don't have to be RAIL/CWV/whatever FAST™ to count as a PWA (the perf category is for FAST™). So the emphasis is on the "enough" part of "fast enough" :) |
For 6.0 we also discussed adding metrics other than TTI in this audit, but didn't come up with any concrete ideas. @cheneytsai was helping look at getting TBT involved here, but I don't think we had any GH issue for tracking that. |
We could also align with the TWA criteria of perf score 80: https://blog.chromium.org/2019/02/introducing-trusted-web-activity-for.html |
All possible options
Let's raise this with the larger PWA group. |
Couple of thoughts but agree to raise with larger group:
|
Just wanted to add to Cheney's thoughts, that after working with several partners on PWAs, the bullet that they keep failing all the time is the performance one (TTI). I think the problem with keeping that metric is that: (1) it has more variance than others, which can make the test show as pass/failed alternatively even during the same day (2) it's harder to improve than others, which makes it less actionable. As a result companies end up staying in a non-PWA state endlessly (specially those which business models that depend heavily on things like ads / 3rd party scripts). |
We're steering towards removing the perf audit from the PWA category. Next action was on @b1tr0t. On the Lighthouse side we'll have to figure out what we'll do with the "fast and reliable" group. |
Summary
"Fast enough" is determined by TTI: https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/load-fast-enough-for-pwa.js#L22
Seems like this should be based off of CWV thresholds?
The text was updated successfully, but these errors were encountered: